Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in a GIFAnimatedImage extension #24031

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Fix crash in a GIFAnimatedImage extension #24031

merged 1 commit into from
Jan 30, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Jan 30, 2025 •
edited
Loading

Fixes #24030

To test:

  • Test Reader feed that have some GIFs

Note: there are some existing issues with restart of animations on reload. I believe they've been there before.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 25.8 milestone Jan 30, 2025
@dangermattic
Copy link
Collaborator

1 Error
🚫 PR requires at least one label.
1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@kean kean mentioned this pull request Jan 30, 2025
Closed
kean
kean commented Jan 30, 2025
View reviewed changes
Modules/Sources/AsyncImageKit/Views/AsyncImageView.swift
@@ -185,7 +185,7 @@ extension GIFImageView {
}
}

public func prepareForReuse() {
public func reset() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this code to an extension without realizing the method named prepareForReuse already existed on GIFAnimatable. There needs to be a more durable solution, but I fixed it like this for now.

The issue with the standard prepareForReuse is that it only works for animated images, AFAIR.

@kean kean requested a review from crazytonyli January 30, 2025 02:15
@kean kean enabled auto-merge (squash) January 30, 2025 02:21
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24031-c53811d
Version25.7
Bundle IDorg.wordpress.alpha
Commitc53811d
App Center BuildWPiOS - One-Offs #11427
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24031-c53811d
Version25.7
Bundle IDcom.jetpack.alpha
Commitc53811d
App Center Buildjetpack-installable-builds #10460
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean merged commit a6875ba into release/25.7 Jan 30, 2025
23 of 26 checks passed
@kean kean deleted the fix/crash-in-gif-animated-image-extension branch January 30, 2025 02:47
oguzkocer pushed a commit that referenced this pull request Jan 31, 2025
@kean @oguzkocer
Fix crash in a GIFAnimatedImage extension (#24031)
e32e265
github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2025
@wpmobilebot @kean
Merge release/25.7 into trunk (#24034)
f892b5f 
* Fix crash in a GIFAnimatedImage extension (#24031)

* Update WordPress metadata translations

* Bump version number

---------

Co-authored-by: Alex Grebenyuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazytonyli crazytonyli crazytonyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
25.8
Development

Successfully merging this pull request may close these issues.
4 participants
@kean @dangermattic @wpmobilebot @crazytonyli